[PATCH] D42047: [PatternMatch] Implement matching code for LibFunc

Dmitry Venikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 06:30:12 PST 2019


Quolyk added a comment.

In D42047#1164773 <https://reviews.llvm.org/D42047#1164773>, @lebedev.ri wrote:

> In D42047#1164770 <https://reviews.llvm.org/D42047#1164770>, @Quolyk wrote:
>
> > In D42047#1164762 <https://reviews.llvm.org/D42047#1164762>, @lebedev.ri wrote:
> >
> > > Is it possible to add some unit test for this?
> >
> >
> > I have not seen that this header is explicitly tested, but it can be tested througn some libFunc pattern matches, as I hope to introduce some using this
>
>
> `unittests/IR/PatternMatch.cpp`


I don't see that all patterns are tested in that file. Instead, patterns are tested implicitly in optimization transforms.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42047/new/

https://reviews.llvm.org/D42047





More information about the llvm-commits mailing list