[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 02:59:11 PST 2019


jhenderson updated this revision to Diff 185016.
jhenderson marked 2 inline comments as done.
jhenderson added a comment.

- Reword some unit-test comments.
- Pulled out some common logic into a small function.
- Renamed some variables to be more consistent with existing naming structure (this kind of switch is named in the following style: `--<arg>=<option>`).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030

Files:
  lib/Support/CommandLine.cpp
  tools/llvm-symbolizer/llvm-symbolizer.cpp
  unittests/Support/CommandLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57030.185016.patch
Type: text/x-patch
Size: 14725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190204/c23792fd/attachment-0001.bin>


More information about the llvm-commits mailing list