[PATCH] D56470: [NewPM] Second attempt at porting ASan
Fedor Sergeev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 00:46:25 PST 2019
fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
LGTM bar the small nit below.
================
Comment at: clang/test/CodeGen/asan-new-pm.ll:22-25
+; CHECK:; <label>:11: ; preds = %6
+; CHECK: call void @__asan_report_load4(i64 %0)
+; CHECK: call void asm sideeffect "", ""()
+; CHECK: unreachable
----------------
If I get it right, the primary goal of this test is to check that address sanitizer actually kicks in for the new pass manager with -fexperimental-new-pass-manager -fsanitize=address.
Then the only check that needs to be done here is the presence of __asan instrumentation function calls and thats all.
No need to check exact sequence of instructions in the function, which might be subject to change depending on how -O1 is packed with optimizations.
And then perhaps you can even skip -O1.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56470/new/
https://reviews.llvm.org/D56470
More information about the llvm-commits
mailing list