[PATCH] D57640: [NewPM][MSan] Add Options Handling

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/MemorySanitizer.h:32
+FunctionPass *
+createMemorySanitizerLegacyPassPass(MemorySanitizerOptions Options);
 
----------------
Is there a reason why this function no longer specifies default value for the parameter?
Before the change it was possible to call it w/o passing anything at all.

Btw, there is one use - in llvm/bindings/go/llvm/InstrumentationBindings.cpp, which dont seem to be addressed
by your change and it does call createMemorySanitizerLegacyPassPass w/o passing arguments.





Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57640/new/

https://reviews.llvm.org/D57640