[PATCH] D57599: Compute the correct symbol size in llvm-nm even without --print-size

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL353011: Compute the correct symbol size in llvm-nm even without --print-size (authored by ssrivastava, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D57599?vs=184778&id=184978#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57599/new/

https://reviews.llvm.org/D57599

Files:
  llvm/trunk/test/tools/llvm-nm/X86/posixELF.test
  llvm/trunk/test/tools/llvm-nm/X86/response-file.test
  llvm/trunk/tools/llvm-nm/llvm-nm.cpp


Index: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp
@@ -1190,10 +1190,8 @@
       NMSymbol S = {};
       S.Size = 0;
       S.Address = 0;
-      if (PrintSize) {
-        if (isa<ELFObjectFileBase>(&Obj))
-          S.Size = ELFSymbolRef(Sym).getSize();
-      }
+      if (isa<ELFObjectFileBase>(&Obj))
+        S.Size = ELFSymbolRef(Sym).getSize();
       if (PrintAddress && isa<ObjectFile>(Obj)) {
         SymbolRef SymRef(Sym);
         Expected<uint64_t> AddressOrErr = SymRef.getAddress();
Index: llvm/trunk/test/tools/llvm-nm/X86/response-file.test
===================================================================
--- llvm/trunk/test/tools/llvm-nm/X86/response-file.test
+++ llvm/trunk/test/tools/llvm-nm/X86/response-file.test
@@ -1,5 +1,5 @@
 # RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response
 # RUN: llvm-nm @%t-response | FileCheck %s
 
-CHECK: main T 0 0
+CHECK: main T 0 15
 CHECK: puts U 0 0
Index: llvm/trunk/test/tools/llvm-nm/X86/posixELF.test
===================================================================
--- llvm/trunk/test/tools/llvm-nm/X86/posixELF.test
+++ llvm/trunk/test/tools/llvm-nm/X86/posixELF.test
@@ -1,4 +1,4 @@
 # RUN: llvm-nm -P %p/Inputs/hello.obj.elf-x86_64 | FileCheck %s
 
-CHECK: main T 0 0
+CHECK: main T 0 15
 CHECK: puts U 0 0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57599.184978.patch
Type: text/x-patch
Size: 1435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190203/0fcbdc07/attachment.bin>