[PATCH] D57372: Demanded elements support for masked.load and masked.gather

[Philip Reames via Phabricator via llvm-commits]

reames marked an inline comment as done.
reames added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1455
+            DemandedPtrs.clearBit(i);
+          else if (CElt->isAllOnesValue())
+            DemandedPassThrough.clearBit(i);
----------------
RKSimon wrote:
> We're not 100% consistent with this but for selects we try to use:
> 
> ```
> if (CElt->isNullValue())
>   DemandedPtrs.clearBit(i);
> else
>   DemandedPassThrough.clearBit(i);
> ```
This would be wrong.  Consider any constant expr or other constant of indeterminate value.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57372/new/

https://reviews.llvm.org/D57372