[PATCH] D57637: [X86] Lower ISD::UADDO to use the Z flag instead of C flag when the RHS is a constant 1 to encourage INC formation.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D57637#1382186 <https://reviews.llvm.org/D57637#1382186>, @craig.topper wrote:

> The combineCarryThroughADD prevents some regressions from the getX86XALUOOp change. But I think it picked up a change to at least codegen-prepare-uaddo.ll by itself. I can commit the combineCarryThroughADD separately first if you want.


No need to intro regressions - I noticed regressions to the alternate proposal in D57547 <https://reviews.llvm.org/D57547> when I extended that to handle COND_B --> COND_E, so I was just wondering if this was avoiding that. Might be a potential follow-up for a USUBO / dec sibling to this? Not sure if we have as much test coverage for those.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57637/new/

https://reviews.llvm.org/D57637