[PATCH] D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used.
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 19:12:40 PST 2019
smeenai added inline comments.
================
Comment at: CMakeLists.txt:113
endif()
+set(LLVM_ENABLE_PROJECTS_USED OFF CACHE BOOL "")
+mark_as_advanced(LLVM_ENABLE_PROJECTS_USED)
----------------
Should this be FORCE as well, to handle a configure with LLVM_ENABLE_PROJECTS followed by a configure without one?
================
Comment at: CMakeLists.txt:154
+ STATUS
+ "Setting LLVM_TOOL_${upper_proj}_BUILD to ${SHOULD_ENABLE_PROJ}")
+ set(LLVM_TOOL_${upper_proj}_BUILD
----------------
This will be pretty noisy ... is this a debugging leftover?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57535/new/
https://reviews.llvm.org/D57535
More information about the llvm-commits
mailing list