[PATCH] D57629: [LoopIdiomRecognize] @llvm.dbg values shouldn't affect the transformation.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 17:07:24 PST 2019


aprantl added a comment.

LGTM with a little simpler testcase



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1467
+  uint32_t HeaderSize =
+      std::distance(InstWithoutDebugIt.begin(), InstWithoutDebugIt.end());
+
----------------
aprantl wrote:
> I would be surprised if this is the only occurrence of this exact bug...
We should probably grep for "cost" in the optimizer.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57629/new/

https://reviews.llvm.org/D57629





More information about the llvm-commits mailing list