[PATCH] D57285: AMDGPU/GlobalISel: Legalize constant for pointer types

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-constant.mir:102
+    ; CHECK-LABEL: name: test_constant_p0
+    ; CHECK: [[C:%[0-9]+]]:_(p0) = G_CONSTANT i32 0
+    ; CHECK: $vgpr0_vgpr1 = COPY [[C]](p0)
----------------
tstellar wrote:
> Does this need to be i64 here?  Same for the other 64-bit address spaces.
I'm not sure what the policy is for the integer size on G_CONSTANT. The verifier doesn't complain. buildConstant does a sextOrTrunc to convert to the element type. I'll fix this before committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57285/new/

https://reviews.llvm.org/D57285