[PATCH] D57616: [DAGCombiner] Discard pointer info when combining extract_vector_elt of a vector load when the index isn't constant

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 15:18:00 PST 2019


efriedma added a comment.

This is a little unfortunate, but looks correct.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15645
+    // access isn't in the default address space.
+    if (OriginalLoad->getPointerInfo().getAddrSpace() != 0)
+      return SDValue();
----------------
MachinePointerInfo has a constructor which takes an address-space (see https://reviews.llvm.org/rL319622 ).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57616/new/

https://reviews.llvm.org/D57616





More information about the llvm-commits mailing list