[PATCH] D57027: [AMDGPU] Factored PAL metadata handling out into its own class

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 13:48:56 PST 2019


scott.linder added a comment.
Herald added a project: LLVM.

The code looks good to me, but I'm wondering why the move from doing this in `AsmPrinter::EmitEndOfAsmFile` to `TargetStreamer::finish`? It seems like it is fine to emit directives in either, but I don't understand why the change here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57027/new/

https://reviews.llvm.org/D57027





More information about the llvm-commits mailing list