[PATCH] D57023: [MsgPack] New MsgPackDocument class
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 11:42:40 PST 2019
scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.
Herald added a project: LLVM.
LGTM, sorry for the delay in reviewing this.
This changes how tags are handled and removes the ability to "ignore tags" completely, but it achieves the same result of not littering the YAML with annotations in the usual case. I can see some corner cases where a stray tag will now appear in the YAML where it would not have before, but I think your solution is cleaner.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57023/new/
https://reviews.llvm.org/D57023
More information about the llvm-commits
mailing list