[PATCH] D57416: [AMDGPU] Support emitting GOT relocations for function calls

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 11:09:26 PST 2019


scott.linder added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3496
-    } else {
-      MIB = BuildMI(*BB, MI, DL, TII->get(AMDGPU::SI_TCRETURN))
-        .add(MI.getOperand(0))
----------------
arsenm wrote:
> What happened to TCRETURN? I'm pretty sure we need this
After removing the need to insert the original global here there was nothing to do for TCRETURN in the custom inserter, so I just deleted the _ISEL variant and used tablegen to legalize ISD::TC_RETURN directly to SI_TCRETURN.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57416/new/

https://reviews.llvm.org/D57416





More information about the llvm-commits mailing list