[PATCH] D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping.

[Matt Davis via Phabricator via llvm-commits]

mattd marked 2 inline comments as done and an inline comment as not done.
mattd added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:345
+                                   cl::boolOrDefault PrintSectionMapping) = 0;
+  virtual void printSectionMapping(const ELFFile<ELFT> *Obj) = 0;
   virtual void printHashHistogram(const ELFFile<ELFT> *Obj) = 0;
----------------
jhenderson wrote:
> jhenderson wrote:
> > Can you remove this?
> Ping? I don't think you need this in the base class interface - it doesn't need to exist as the section mapping printing is a detail of the program header printing, so it probably should be removed.
My bad, that should not have been in the current patch.  I had marked it done, I'll make sure it doesn't show up when I land this, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57365/new/

https://reviews.llvm.org/D57365