[PATCH] D57530: Order File Instrumentation: dump the data in compiler-rt

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/profile/InstrProfilingFile.c:687
+  FilenameBuf = (char *)COMPILER_RT_ALLOCA(Length + 1);
+  Filename = getCurFilename(FilenameBuf, 0);
+
----------------
I suggest not using the main file for order dumping for a couple of reasons:

1) To append it into the main file, you will need to update the raw header to set order file size
2) you will need to add profile merging support for ordering file. It can be tricky as the value profile data length is variable from run to run

To dump into a separate file, you can use the main filename as the base with a differnent suffix:

main file:   default_xxx.profraw
order file: default_xxx.order, or simply default_xxx.profraw.order


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57530/new/

https://reviews.llvm.org/D57530