[PATCH] D57575: [LLD] [COFF] Create range extension thunks for ARM64

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:374-380
+  RangeExtensionThunk *C;
+  switch (Config->Machine) {
+  case ARMNT:
+    C = make<RangeExtensionThunkARM>(Target);
+    break;
+  case ARM64:
+    C = make<RangeExtensionThunkARM64>(Target);
----------------
This is the only place you are using RangeExtensionThunk{ARM,ARM64} as RangeExtensionThunk, but you can easily avoid it. So, RangeExtensionThunk class doesn't seem necessary. Can you remove that class and make RangeExtensionThunk{ARM,ARM64} directly inherit Chunk, so that you have shallower class hierarchy?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57575/new/

https://reviews.llvm.org/D57575