[PATCH] D57539: [InstCombine] Extra null-checking on TFE/LWE support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 09:26:50 PST 2019


arsenm added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/crash.tfe.ll:1
+; RUN: opt -instcombine -S -mtriple=amdgcn-amd-amdhsa -o - %s
+define protected <4 x half> @__llvm_amdgcn_image_sample_d_1darray_v4f16_f32_f32(i32, float, float, float, float, <8 x i32>, <4 x i32>, i1 zeroext, i32, i32) local_unnamed_addr {
----------------
This is going to fail if AMDGPU isn't built. This should go in test/Transforms/InstCombine/AMDGPU/amdgcn-demanded-vector-elts.ll with the others


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57539/new/

https://reviews.llvm.org/D57539





More information about the llvm-commits mailing list