[PATCH] D57541: [DAGCombiner] Eliminate dead stores to stack.

[Nirav Dave via Phabricator via llvm-commits]

niravd added a comment.

In D57541#1380701 <https://reviews.llvm.org/D57541#1380701>, @courbet wrote:

> I just realized that there is nothing that guarantees that an alloca's lifetime is ended in one go, so I'll also have to check that the store is within the lifetime.end base and size.


Yes. You should use the BaseIndexOffset alias framework here.

Also, you'll need to deal with the additional output from indexed stores.

We should probably also add this some LIFETIME nodes casing to FindBetterChains and improve LIFETIME_END's chain so we can deal with overlapping lifetimes.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57541/new/

https://reviews.llvm.org/D57541