[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac
Ilya Biryukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 03:09:46 PST 2019
ilya-biryukov added a comment.
@arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place.
There are two issues still pending:
- `index-file.cu` still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just patch this in locally and run the test.
- I'm not sure it's safe to use temporary storage for `argv[0]` in `clang_parseTranslationUnit2`. The resulting translation units probably holds references to `argv` and is free to read the data later. A simple and safe alternative would be to store this string in `CIndexer` and return a reference here. Does that LG?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57532/new/
https://reviews.llvm.org/D57532
More information about the llvm-commits
mailing list