[PATCH] D57573: Disable tidy checks with too many hits
Haojian Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 02:57:34 PST 2019
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
I'm +1 on disabling these checks as they add too much noise in editors (even though the naming check is correct, we can't do a global cleanup on the codebase). Let's commit it, we could revert it if someone has other concerns.
================
Comment at: clang/.clang-tidy:2
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming'
+# Note that the naming checks are disabled, there are too many violations in the codebase.
+# Naming settings are kept for documentation purposes and in cases where one would enable the check by
----------------
"naming checks" => `readability-identifier-naming check`. Maybe also mention these violations add too much noise in editors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57573/new/
https://reviews.llvm.org/D57573
More information about the llvm-commits
mailing list