[PATCH] D57310: GlobalISel: Consolidate load/store legalization
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 31 18:06:24 PST 2019
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:582-584
- if (MMO.getOrdering() != AtomicOrdering::NotAtomic ||
- MMO.getFailureOrdering() != AtomicOrdering::NotAtomic)
- return UnableToLegalize;
----------------
aemerson wrote:
> paquette wrote:
> > Are these atomic checks still handled somewhere?
> Looks like it's handled in reduceLoadStoreWidth.
Yes, those were missing from the vector version but I fixed that in r352334, so now both cases are In reduceLoadStoreWidth
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57310/new/
https://reviews.llvm.org/D57310
More information about the llvm-commits
mailing list