[PATCH] D57533: lit: support long paths on Windows

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked an inline comment as done.
compnerd added a comment.

Ugh, right ... I think that I had tested it against an empty directory!  It was run early in the test.  I'll flesh this out with @zturner's idea of extract it into a helper.



================
Comment at: utils/lit/lit/TestRunner.py:619
+                    path = os.path.abspath(path)
+                    if not ctypes.windll.kernel32.RemoveDirectoryW(r'\\?\%s' % path):
+                        raise ctypes.WinError()
----------------
smeenai wrote:
> Shouldn't the error handling logic match the other branch (`on_rm_error if force else None`)?
Hmm, yeah, `RemoveDirectoryW` could loop back around...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533