[PATCH] D57500: [WebAssembly] clang-tidy (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 17:19:20 PST 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: lib/MC/MCSectionWasm.cpp:17
 
-MCSectionWasm::~MCSectionWasm() {} // anchor.
-
----------------
aheejin wrote:
> sbc100 wrote:
> > I guess you are removing this anchor because we have other methods below?   
> Its declaration is marked as `= default` in `include/llvm/MC/MCSectionWasm.h`, like
> ```
> ~MCSectionWasm() = default; 
> ```
By the way it was also deleted from the header file anyway.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57500/new/

https://reviews.llvm.org/D57500





More information about the llvm-commits mailing list