[PATCH] D57500: [WebAssembly] clang-tidy (NFC)
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 31 17:18:28 PST 2019
aheejin updated this revision to Diff 184649.
aheejin marked 25 inline comments as done.
aheejin added a comment.
Herald added a project: LLVM.
Thank you for the feedback! Addressed comments:
- Delete constructors/destructors marked as `= default` when not necessary
- Revert all changes related to `modernize-return-braced-init-list` warning
- Revert function name changes when they are inconsistent with overriden ones
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57500/new/
https://reviews.llvm.org/D57500
Files:
include/llvm/MC/MCSectionWasm.h
include/llvm/MC/MCWasmStreamer.h
lib/BinaryFormat/Wasm.cpp
lib/MC/MCParser/WasmAsmParser.cpp
lib/MC/MCSectionWasm.cpp
lib/MC/MCWasmObjectTargetWriter.cpp
lib/MC/MCWasmStreamer.cpp
lib/MC/WasmObjectWriter.cpp
lib/Object/WasmObjectFile.cpp
lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.h
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.cpp
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyWasmObjectWriter.cpp
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
lib/Target/WebAssembly/WebAssemblyCFGSort.cpp
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
lib/Target/WebAssembly/WebAssemblyCallIndirectFixup.cpp
lib/Target/WebAssembly/WebAssemblyFastISel.cpp
lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
lib/Target/WebAssembly/WebAssemblyMCInstLower.h
lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp
lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.h
lib/Target/WebAssembly/WebAssemblyMemIntrinsicResults.cpp
lib/Target/WebAssembly/WebAssemblyOptimizeLiveIntervals.cpp
lib/Target/WebAssembly/WebAssemblyOptimizeReturned.cpp
lib/Target/WebAssembly/WebAssemblyPeephole.cpp
lib/Target/WebAssembly/WebAssemblyPrepareForLiveIntervals.cpp
lib/Target/WebAssembly/WebAssemblyRegColoring.cpp
lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.h
lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.cpp
lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.h
lib/Target/WebAssembly/WebAssemblySetP2AlignOperands.cpp
lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
lib/Target/WebAssembly/WebAssemblyTargetMachine.h
lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
tools/llvm-objdump/WasmDump.cpp
tools/llvm-readobj/WasmDumper.cpp
tools/obj2yaml/wasm2yaml.cpp
tools/yaml2obj/yaml2wasm.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57500.184649.patch
Type: text/x-patch
Size: 146456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190201/9e5690ed/attachment-0001.bin>
More information about the llvm-commits
mailing list