[compiler-rt] r352815 - [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
Jonathan Metzman via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 31 15:34:57 PST 2019
Author: metzman
Date: Thu Jan 31 15:34:56 2019
New Revision: 352815
URL: http://llvm.org/viewvc/llvm-project?rev=352815&view=rev
Log:
[libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
Summary:
Temporarily disable value-profile-cmp2.test on Win.
https://reviews.llvm.org/D57465 causes the test to fail on Win.
However, it seems that the behavior of libFuzzer on Win was broken
before that patch. It crashes in the exit handler when not used with
ASAN. Prior to the patch, the crash handler would run, tricking the
test into thinking libFuzzer on Win had exited properly.
Reviewers: morehouse, vitalybuka
Reviewed By: morehouse
Subscribers: yln
Differential Revision: https://reviews.llvm.org/D57551
Modified:
compiler-rt/trunk/test/fuzzer/value-profile-cmp2.test
Modified: compiler-rt/trunk/test/fuzzer/value-profile-cmp2.test
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/fuzzer/value-profile-cmp2.test?rev=352815&r1=352814&r2=352815&view=diff
==============================================================================
--- compiler-rt/trunk/test/fuzzer/value-profile-cmp2.test (original)
+++ compiler-rt/trunk/test/fuzzer/value-profile-cmp2.test Thu Jan 31 15:34:56 2019
@@ -1,4 +1,6 @@
UNSUPPORTED: ios
+FIXME: Make libFuzzer handle exits without ASan properly on Windows.
+UNSUPPORTED: windows
CHECK: BINGO
RUN: %cpp_compiler -fno-sanitize=address %S/SimpleHashTest.cpp -o %t-SimpleHashTest
RUN: not %run %t-SimpleHashTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=100000000 -max_len=64 2>&1 | FileCheck %s
More information about the llvm-commits
mailing list