[PATCH] D57546: [WebAssembly] Make segment/size/type directives optional in asm

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 14:43:48 PST 2019


aardappel created this revision.
aardappel added reviewers: dschuff, sbc100.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google.

These were "boilerplate" that repeated information already present
in .functype and end_function, that needed to be repeated to Please
the particular way our object writing works, and missing them would
generate errors.

Instead, we generate the information for these automatically so the
user can concern itself with writing more canonical wasm functions
that always work as expected.


Repository:
  rL LLVM

https://reviews.llvm.org/D57546

Files:
  lib/MC/MCParser/WasmAsmParser.cpp
  lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  test/MC/WebAssembly/assembler-binary.ll
  test/MC/WebAssembly/basic-assembly-errors.s
  test/MC/WebAssembly/basic-assembly.s
  test/MC/WebAssembly/objdump.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57546.184619.patch
Type: text/x-patch
Size: 7111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/641fbd59/attachment.bin>


More information about the llvm-commits mailing list