[PATCH] D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 14:11:13 PST 2019


spatel added a comment.

I see what happened here.
This patch was based on something after rL352766 <https://reviews.llvm.org/rL352766>, so it picked up the test diffs that were mistakenly omitted by the first rev of D57516 <https://reviews.llvm.org/D57516>.
On its own, this patch shows no test diffs, so Nirav proceeded with committing this after rL352769 <https://reviews.llvm.org/rL352769>.

D57516 <https://reviews.llvm.org/D57516> has *no* interaction with this patch AFAICT. That makes a lot more sense than both patches tickling exactly the same set of regression tests.

I have a separate x86 patch in progress to avoid the add->inc seen in the other patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57520/new/

https://reviews.llvm.org/D57520





More information about the llvm-commits mailing list