[PATCH] D56470: [NewPM] Second attempt at porting ASan

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:529
 
-/// AddressSanitizer: instrument the code in module to find memory bugs.
-struct AddressSanitizer : public FunctionPass {
-  // Pass identification, replacement for typeid
+bool ShouldCompileKernel(bool CompileKernel) {
+  return ClEnableKasan.getNumOccurrences() > 0 ? ClEnableKasan : CompileKernel;
----------------
philip.pfaffe wrote:
> No need to pull this out!
> 
> As a followup, I want to add options handling just like we did for loop unrolling. Then this will get unified in a much nicer way!
Done. I assume also rL350808 is the commit you are referring to? Should that be a patch separate from this or added on top of this also? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56470/new/

https://reviews.llvm.org/D56470