[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

Alex Lorenz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 13:42:06 PST 2019


arphaman requested changes to this revision.
arphaman added a comment.
This revision now requires changes to proceed.

The real problem is that `clang_parseTranslationUnit2` is broken, so this just fixes one client, `c-index-test`. All other macOS clients that call that function will still be unable to find the libc++ headers.

`clang_parseTranslationUnit2` should try to infer the binary directory based on the libclang path. Libclang already does that for `-resource-dir`, see (CIndexer::getClangResourceDir). I think that you should set the `clang` path to `CINdexer::getClangToolchainPath()`/bin/clang, and that should fix the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57532/new/

https://reviews.llvm.org/D57532





More information about the llvm-commits mailing list