[PATCH] D57479: [WebAssembly] MC: Fix for outputing wasm object to /dev/null

[Sam Clegg via Phabricator via llvm-commits]

sbc100 updated this revision to Diff 184581.
sbc100 added a comment.

- Fix type of Size


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57479/new/

https://reviews.llvm.org/D57479

Files:
  lib/MC/WasmObjectWriter.cpp
  test/MC/WebAssembly/null-output.s


Index: test/MC/WebAssembly/null-output.s
===================================================================
--- /dev/null
+++ test/MC/WebAssembly/null-output.s
@@ -0,0 +1,10 @@
+# RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=obj -o /dev/null < %s
+
+    .text
+    .section .text.main,"",@
+    .type    main, at function
+main:
+    .functype   main (i32, i32) -> (i32)
+    end_function
+.Lfunc_end0:
+    .size main, .Lfunc_end0-main
Index: lib/MC/WasmObjectWriter.cpp
===================================================================
--- lib/MC/WasmObjectWriter.cpp
+++ lib/MC/WasmObjectWriter.cpp
@@ -398,8 +398,14 @@
 // Now that the section is complete and we know how big it is, patch up the
 // section size field at the start of the section.
 void WasmObjectWriter::endSection(SectionBookkeeping &Section) {
-  uint64_t Size = W.OS.tell() - Section.PayloadOffset;
-  if (uint32_t(Size) != Size)
+  uint64_t Size = W.OS.tell();
+  // /dev/null doesn't support seek/tell and can report offset of 0.
+  // Simply skip this patching in that case.
+  if (!Size)
+    return;
+
+  Size -= Section.PayloadOffset;
+  if (Size && uint32_t(Size) != Size)
     report_fatal_error("section size does not fit in a uint32_t");
 
   LLVM_DEBUG(dbgs() << "endSection size=" << Size << "\n");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57479.184581.patch
Type: text/x-patch
Size: 1295 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/95467ae4/attachment.bin>