[PATCH] D57533: lit: support long paths on Windows

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 12:46:55 PST 2019


ruiu added a comment.

In D57533#1379277 <https://reviews.llvm.org/D57533#1379277>, @compnerd wrote:

> @ruiu, no unfortunately, not all the paths can be shortened in the swift test suite since it is such a heavy user of the clang modules, modules cache paths and module naming structure in clang is a problem.  Perhaps if we could make `%t` in lit be short and clang module names to be short, it might be possible to get the paths to a size that works?


If you can do that, that's much more preferable solution than fixing the problem only at this location. I'd think if your test file get a very long pathname, this is not the only place that could break. For example, if you use `rm` on a test file and the test file gets a long pathname, that could fail.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list