[llvm] r352790 - [cmake] Note future cleanup in comment. NFC

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 12:32:45 PST 2019


Author: smeenai
Date: Thu Jan 31 12:32:45 2019
New Revision: 352790

URL: http://llvm.org/viewvc/llvm-project?rev=352790&view=rev
Log:
[cmake] Note future cleanup in comment. NFC

CMake 3.6 introduced CMAKE_TRY_COMPILE_PLATFORM_VARIABLES, which solves
precisely the problem that necessitated init_user_prop, so we can switch
over whenever we bump our minimum CMake requirement.

Modified:
    llvm/trunk/cmake/platforms/WinMsvc.cmake

Modified: llvm/trunk/cmake/platforms/WinMsvc.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/platforms/WinMsvc.cmake?rev=352790&r1=352789&r2=352790&view=diff
==============================================================================
--- llvm/trunk/cmake/platforms/WinMsvc.cmake (original)
+++ llvm/trunk/cmake/platforms/WinMsvc.cmake Thu Jan 31 12:32:45 2019
@@ -92,7 +92,9 @@
 # won't see the value of any arguments the user passed via -D.  Since these are
 # necessary to properly configure MSVC in both the top-level configuration as well as
 # all feature-test invocations, we set environment variables with the values so that
-# these environments get inherited by child invocations.
+# these environments get inherited by child invocations. We can switch to
+# CMAKE_TRY_COMPILE_PLATFORM_VARIABLES once our minimum supported CMake version
+# is 3.6 or greater.
 function(init_user_prop prop)
   if(${prop})
     set(ENV{_${prop}} "${${prop}}")




More information about the llvm-commits mailing list