[PATCH] D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 11:17:09 PST 2019


niravd added a comment.

Hmm , weird. I've been looking at reasons why D57367 <https://reviews.llvm.org/D57367> is doing so much when I found the case generating dangling node. I _was_ a bit surprised that this causes that regression, but it must be the case that dangling nodes persist to ISel and prevent folding. Presumably your change allowed CombineZExtLogicOpShiftLoad to trigger.

In any case, this is obvious cleanup and rebasing past your revert this is NFCish as expected again. I'll land this presently.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57520/new/

https://reviews.llvm.org/D57520





More information about the llvm-commits mailing list