[PATCH] D57489: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 11:04:50 PST 2019


vsk added a comment.

Looks reasonable to me.



================
Comment at: llvm/test/Instrumentation/AddressSanitizer/instrument-no-return.ll:3
 ; AddressSanitizer must insert __asan_handle_no_return
-; before every noreturn call or invoke.
+; before most noreturn call or invoke.
 
----------------
Could you make this more specific? E.g. 'noreturn calls that aren't inserted by sanitizers'.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57489/new/

https://reviews.llvm.org/D57489





More information about the llvm-commits mailing list