[PATCH] D54720: [PPC64] toc-indirect to toc-relative relaxation.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, but I have one question.



================
Comment at: ELF/Arch/PPC64.cpp:137
+  // have less relocations then toc enties and Relas[Index] is the last reloc
+  // in the array. In this case we have nothing to relax to.
+  if (Offset > Relas[Index].r_offset)
----------------
I think I don't understand why you can't relax if the number of relocations for the .toc is smaller than the number of entires in .toc. I thought that if you can find a relocation that has a specific offset, that's the relocation that you are looking for, and you can read a symbol and an offset from that relocation. I think there's something more about PPC64 ABI that I don't know of. Could you explain?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54720/new/

https://reviews.llvm.org/D54720