[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

[Ilya Biryukov via Phabricator via llvm-commits]

ilya-biryukov added a comment.

In D57509#1378943 <https://reviews.llvm.org/D57509#1378943>, @ioeric wrote:

> Yes, but a new option seems a bit of an overkill here.  The text is appended and doesn't seem to affect the readability of original diagnostic message much (IMO).  Could you elaborate why this is undesirable in vscode for you?


It's basically just noise, as VSCode shows the bulb icons whenever you hover over the diagnostics with errors.
Having a standard suffix in half of the diagnostics seems undesirable.

Adding a suffix like this should be left to the client, i.e. it's clear this is desirable in vim which does not have other UI indicators and adds noise in VSCode, which uses bulb icons for those purposes.
I do agree that plumbing the parameters is annoying, but this does look like a thing where different clients might diverge in how they present results and it's totally looks fine.
Note that command-line argument is not the only way to do this, e.g. we could also have a special capability as an extension that would turn these messages of (`clangd.addFixAvailableMessage`) and send it from VSCode. That's totally doable, since we control the extension.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57509/new/

https://reviews.llvm.org/D57509