[PATCH] D57499: [WebAssembly] clang-tidy (NFC)

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Otherwise LGTM



================
Comment at: wasm/InputChunks.cpp:43
   if (Index == UINT32_MAX)
-    return StringRef();
+    return {};
   return File->getWasmObj()->linkingData().Comdats[Index];
----------------
I prefer the previous explicit version myself.. otherwise one has to visually cross reference the return type to see what is being returned here is an empty string.


================
Comment at: wasm/Writer.cpp:1114
 
-static const int OPCODE_CALL = 0x10;
-static const int OPCODE_END = 0xb;
----------------
Can you leave these for now.  I kind of like them being this format, plus I have a CL pending to add more and move them to a header file.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57499/new/

https://reviews.llvm.org/D57499