[PATCH] D57515: lld-link: Allow mixing 'discard' and 'largest' comdat selections

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm

Maybe also make it clear in the commit message that link.exe allows this.



================
Comment at: lld/COFF/InputFiles.cpp:488
+           LeaderSelection == IMAGE_COMDAT_SELECT_ANY)) {
+        // cl.exe picks "any" for vftables when building with /GR- and
+        // "largest" when building with /GR. To be able to link object files
----------------
ultra nit: maybe s/picks/uses/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57515/new/

https://reviews.llvm.org/D57515