[PATCH] D57264: Bump minimum toolchain version

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:73
+#include <ciso646>
+#if __GLIBCXX__ < ${GCC_MIN_DATE}
+#error Unsupported
----------------
danilaml wrote:
> hubert.reinterpretcast wrote:
> > I can find `__GLIBCXX__` on GCC 6.x toolchains, but I haven't found it on older ones.
> > ```
> > #include <ciso646>
> > extern char x[__GLIBCXX__]; // error: '__GLIBCXX__' was not declared in this scope
> > ```
> > 
> It seems to be there but it looks like "#include <ciso646>" doesn't define it for older compilers for some reason.
Yes, I see it now. The other thing is that maybe we could check the libstdc++ version for the other-than-known compilers as well (i.e., if we detect libstdc++, then check the version). Although that could be a later patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264