[llvm] r352753 - [llvm-symbolizer][test] Extract tests from llvm-symbolizer.test and simplify (#1)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 06:11:17 PST 2019


Author: jhenderson
Date: Thu Jan 31 06:11:17 2019
New Revision: 352753

URL: http://llvm.org/viewvc/llvm-project?rev=352753&view=rev
Log:
[llvm-symbolizer][test] Extract tests from llvm-symbolizer.test and simplify (#1)

This is the second of a series of patches simplifying llvm-symbolizer
tests. See r352752 for the first. This one splits out 5 distinct test
cases from llvm-symbolizer.test into separate tests, and simplifies them
slightly by using --obj/positional arguments for the input file and
addresses instead of stdin.

See https://bugs.llvm.org/show_bug.cgi?id=40070#c1 for the motivation.

Reviewed by: dblaikie

Differential Revision: https://reviews.llvm.org/D57443

Added:
    llvm/trunk/test/DebugInfo/arange-overlap.test
    llvm/trunk/test/DebugInfo/cross-cu-inlining.test
    llvm/trunk/test/DebugInfo/gcc-local-mem-func.test
    llvm/trunk/test/DebugInfo/high-pc-constant.test
    llvm/trunk/test/DebugInfo/symbolize-stripped.test
Modified:
    llvm/trunk/test/DebugInfo/llvm-symbolizer.test

Added: llvm/trunk/test/DebugInfo/arange-overlap.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/arange-overlap.test?rev=352753&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/arange-overlap.test (added)
+++ llvm/trunk/test/DebugInfo/arange-overlap.test Thu Jan 31 06:11:17 2019
@@ -0,0 +1,4 @@
+RUN: llvm-symbolizer --no-demangle --obj=%p/Inputs/arange-overlap.elf-x86_64 0x714 | FileCheck %s
+
+CHECK: _ZN1S3bazEv
+CHECK-NEXT: {{.*}}arange-overlap.cc:6

Added: llvm/trunk/test/DebugInfo/cross-cu-inlining.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/cross-cu-inlining.test?rev=352753&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/cross-cu-inlining.test (added)
+++ llvm/trunk/test/DebugInfo/cross-cu-inlining.test Thu Jan 31 06:11:17 2019
@@ -0,0 +1,8 @@
+RUN: llvm-symbolizer --obj=%p/Inputs/cross-cu-inlining.x86_64-macho.o 0x17 | FileCheck %s
+
+; func has been inlined into main by LTO. Check that the symbolizer is able
+; to resolve the cross-cu reference and retrieve func's name
+CHECK: func
+CHECK-NEXT: /tmp{{[/\\]}}cross-cu-inlining.c:16:3
+CHECK-NEXT: main
+CHECK-NEXT: /tmp{{[/\\]}}cross-cu-inlining.c:11:0

Added: llvm/trunk/test/DebugInfo/gcc-local-mem-func.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/gcc-local-mem-func.test?rev=352753&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/gcc-local-mem-func.test (added)
+++ llvm/trunk/test/DebugInfo/gcc-local-mem-func.test Thu Jan 31 06:11:17 2019
@@ -0,0 +1,5 @@
+RUN: llvm-symbolizer --no-demangle --obj=%p/Inputs/llvm-symbolizer-local-mem-func-gcc.elf-x86-64 0x61a | FileCheck %s
+
+CHECK-NOT:  local_mem_func
+CHECK:      _ZZ2f1vEN3foo14local_mem_funcEv
+CHECK-NEXT: {{.*}}local-mem-func.cpp:3:0

Added: llvm/trunk/test/DebugInfo/high-pc-constant.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/high-pc-constant.test?rev=352753&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/high-pc-constant.test (added)
+++ llvm/trunk/test/DebugInfo/high-pc-constant.test Thu Jan 31 06:11:17 2019
@@ -0,0 +1,10 @@
+RUN: llvm-symbolizer --inlining --obj=%p/Inputs/dwarfdump-inl-test.high_pc.elf-x86-64 0x568 | FileCheck %s
+
+CHECK:      inlined_h
+CHECK-NEXT: dwarfdump-inl-test.h:3
+CHECK-NEXT: inlined_g
+CHECK-NEXT: dwarfdump-inl-test.h:7
+CHECK-NEXT: inlined_f
+CHECK-NEXT: dwarfdump-inl-test.cc:3
+CHECK-NEXT: main
+CHECK-NEXT: dwarfdump-inl-test.cc:8

Modified: llvm/trunk/test/DebugInfo/llvm-symbolizer.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/llvm-symbolizer.test?rev=352753&r1=352752&r2=352753&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/llvm-symbolizer.test (original)
+++ llvm/trunk/test/DebugInfo/llvm-symbolizer.test Thu Jan 31 06:11:17 2019
@@ -11,7 +11,6 @@ RUN: echo "%p/Inputs/dwarfdump-test4.elf
 RUN: echo "%p/Inputs/dwarfdump-inl-test.elf-x86-64 0x8dc" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-inl-test.elf-x86-64 0xa05" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-inl-test.elf-x86-64 0x987" >> %t.input
-RUN: echo "%p/Inputs/dwarfdump-inl-test.high_pc.elf-x86-64 0x568" >> %t.input
 RUN: cp "%p/Inputs/dwarfdump-test3.elf-x86-64-space" "%t/dwarfdump-test3.elf-x86-64 space"
 RUN: echo "\"%t/dwarfdump-test3.elf-x86-64 space\" 0x640" >> %t.input
 RUN: echo "\"%t/dwarfdump-test3.elf-x86-64 space\" 0x633" >> %t.input
@@ -19,9 +18,6 @@ RUN: echo "\"%t/dwarfdump-test3.elf-x86-
 RUN: echo "%p/Inputs/macho-universal 0x1f84" >> %t.input
 RUN: echo "%p/Inputs/macho-universal:i386 0x1f67" >> %t.input
 RUN: echo "%p/Inputs/macho-universal:x86_64 0x100000f05" >> %t.input
-RUN: echo "%p/Inputs/llvm-symbolizer-local-mem-func-gcc.elf-x86-64 0x61a" >> %t.input
-RUN: echo "%p/Inputs/arange-overlap.elf-x86_64 0x714" >> %t.input
-RUN: echo "%p/Inputs/cross-cu-inlining.x86_64-macho.o 0x17" >> %t.input
 
 RUN: cd %t
 RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
@@ -71,15 +67,6 @@ CHECK-NEXT: dwarfdump-inl-test.cc:3
 CHECK-NEXT: main
 CHECK-NEXT: dwarfdump-inl-test.cc:8
 
-CHECK:      inlined_h
-CHECK-NEXT: dwarfdump-inl-test.h:3
-CHECK-NEXT: inlined_g
-CHECK-NEXT: dwarfdump-inl-test.h:7
-CHECK-NEXT: inlined_f
-CHECK-NEXT: dwarfdump-inl-test.cc:3
-CHECK-NEXT: main
-CHECK-NEXT: dwarfdump-inl-test.cc:8
-
 CHECK: C
 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test3.cc:3
 
@@ -93,20 +80,6 @@ CHECK:      main
 CHECK:      _Z3inci
 CHECK:      _Z3inci
 
-CHECK-NOT: local_mem_func
-CHECK: _ZZ2f1vEN3foo14local_mem_funcEv
-CHECK-NEXT: {{.*}}local-mem-func.cpp:3:0
-
-CHECK: _ZN1S3bazEv
-CHECK-NEXT: {{.*}}arange-overlap.cc:6
-
-; func has been inlined into main by LTO. Check that the symbolizer is able
-; to resolve the cross-cu reference and retrieve func's name
-CHECK: func
-CHECK-NEXT: /tmp{{[/\\]}}cross-cu-inlining.c:16:3
-CHECK-NEXT: main
-CHECK-NEXT: /tmp{{[/\\]}}cross-cu-inlining.c:11:0
-
 RUN: echo "unexisting-file 0x1234" > %t.input2
 RUN: llvm-symbolizer < %t.input2 2>&1 | FileCheck %s --check-prefix=MISSING-FILE
 
@@ -139,12 +112,6 @@ BINARY_C-NEXT: /tmp/dbginfo{{[/\\]}}llvm
 BINARY_C:      _start
 BINARY_C:      {{g$}}
 
-RUN: echo "0x1f1" > %t.input6
-RUN: llvm-symbolizer --obj %p/Inputs/shared-object-stripped.elf-i386 < %t.input6 \
-RUN:   | FileCheck %s --check-prefix=STRIPPED
-
-STRIPPED:  global_func
-
 ; Check that the last of --demangle and --no-demangle wins.
 RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" > %t.input7
 RUN: llvm-symbolizer --demangle < %t.input7 \

Added: llvm/trunk/test/DebugInfo/symbolize-stripped.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/symbolize-stripped.test?rev=352753&view=auto
==============================================================================
--- llvm/trunk/test/DebugInfo/symbolize-stripped.test (added)
+++ llvm/trunk/test/DebugInfo/symbolize-stripped.test Thu Jan 31 06:11:17 2019
@@ -0,0 +1,4 @@
+RUN: llvm-symbolizer 0x1f1 --obj %p/Inputs/shared-object-stripped.elf-i386 \
+RUN:   | FileCheck %s
+
+CHECK: global_func




More information about the llvm-commits mailing list