[PATCH] D57505: gn build: Fix Python 3 write_vcsrevision script compatibility

[Andrew Boyarshin via Phabricator via llvm-commits]

andrew-boyarshin created this revision.
andrew-boyarshin added reviewers: phosek, serge-sans-paille.
Herald added a subscriber: llvm-commits.

Trivial fix: decode was not called for all subprocess.check_output calls.


Repository:
  rL LLVM

https://reviews.llvm.org/D57505

Files:
  llvm/utils/gn/build/write_vcsrevision.py


Index: llvm/utils/gn/build/write_vcsrevision.py
===================================================================
--- llvm/utils/gn/build/write_vcsrevision.py
+++ llvm/utils/gn/build/write_vcsrevision.py
@@ -47,7 +47,7 @@
         use_shell = True
 
     git_dir = subprocess.check_output([git, 'rev-parse', '--git-dir'],
-                                      cwd=LLVM_DIR, shell=use_shell).strip()
+                                      cwd=LLVM_DIR, shell=use_shell).decode().strip()
     if not os.path.isdir(git_dir):
         print('.git dir not found at "%s"' % git_dir, file=sys.stderr)
         return 1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57505.184479.patch
Type: text/x-patch
Size: 615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/e853e87c/attachment.bin>