[PATCH] D56096: Default lowering for experimental.widenable.condition
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 30 21:46:37 PST 2019
mkazantsev marked an inline comment as done.
mkazantsev added inline comments.
================
Comment at: lib/Transforms/Scalar/LowerWidenableCondition.cpp:65
+ return true;
+}
+
----------------
reames wrote:
> At some point down the line, we'll probably want to simplify the CFG here, but that's definitely okay to be a followup.
Not sure if it's worth doing. The typical use case is `br i1 some_cond & WC, label1, label2`; we only have CFG update if we have previously proved that some_cond is trivially true. If it's a frequent situation in practice, we can think about it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56096/new/
https://reviews.llvm.org/D56096
More information about the llvm-commits
mailing list