[PATCH] D57382: [LV] Add planForInterleaving helper, to create VPlan if they are missing.

Wed Jan 30 21:45:48 PST 2019

dcaballe added a comment.

Hey Florian! Thanks a lot for taking care of this! I'm leaving a comment below. Please, let me know what you think.

Diego

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6158
   if (MaxVF == 1)
     return NoVectorization;

----------------
I wondered if we could make `LoopVectorizationPlanner::plan` more interleave group aware, since the code above also builds a vplan for VF=1 and and returns NoVectorization. Maybe we don't have to modify `computeMaxVF` but just pass `InterleaveGroup` flag to `LoopVectorizationPlanner::plan` and make sure a vplan is built when the flag is true. We are already passing `UserVF` so it would be more of the same. In that way we wouldn't need a independent handling for interleaving cases. I wouldn't worried about compile time since the code executed for `InterleaveGroup` would be mostly the code that you have in the new `planForInterleaving`, right?. What do you think?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57382/new/

https://reviews.llvm.org/D57382