[PATCH] D57365: [llvm-readobj] Add a flag to dump just the section-to-segment mapping.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 20:12:52 PST 2019


mattd updated this revision to Diff 184444.
mattd added a comment.

- I took a hint and decided to more the decision to print the section mapping with the program headers down into the dumper classes.  This is similar to how the `printSymbols` and `printDynamicSymbols` are handled.

- I decided to pass the cl::boolOrDefault value down to the dumpers.  As the GNU dumper will use this to dump the section mapping in the default or 'true' case.  Where as the LLVM dumper will only dump the section mapping if the flag is 'true.'  However, the LLVM section mapping dump is not yet implemented.  That functionality should be added in a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57365/new/

https://reviews.llvm.org/D57365

Files:
  llvm/test/tools/llvm-readobj/gnu-phdrs.test
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h
  llvm/tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57365.184444.patch
Type: text/x-patch
Size: 14475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/c088ab19/attachment.bin>


More information about the llvm-commits mailing list