[compiler-rt] r352721 - [libFuzzer] Update Darwin test

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 19:03:06 PST 2019


Author: yln
Date: Wed Jan 30 19:03:06 2019
New Revision: 352721

URL: http://llvm.org/viewvc/llvm-project?rev=352721&view=rev
Log:
[libFuzzer] Update Darwin test

Support for -fsanitize-coverage=trace-pc[-guard] was removed from
libFuzzer, which makes this currently fail.

This commit aligns this Darwin-specific test with its Linux counterpart
which changed in this commit:
https://github.com/llvm/llvm-project/commit/3a94519a777b9ac407a1d5ff5c31ec48b3768eec

Modified:
    compiler-rt/trunk/test/fuzzer/dead-stripping.test

Modified: compiler-rt/trunk/test/fuzzer/dead-stripping.test
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/fuzzer/dead-stripping.test?rev=352721&r1=352720&r2=352721&view=diff
==============================================================================
--- compiler-rt/trunk/test/fuzzer/dead-stripping.test (original)
+++ compiler-rt/trunk/test/fuzzer/dead-stripping.test Wed Jan 30 19:03:06 2019
@@ -2,22 +2,12 @@ REQUIRES: darwin
 
 No dead_strip. Unused code is not removed.
 RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t
-RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
+RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker
 RUN: %run %t -runs=0 2>&1 | FileCheck %s
 
-With dead_strip. Unused code is not removed.
+With dead_strip. Unused code is (currently) not removed. (It would be better if it was removed!)
 RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -Wl,-dead_strip
-RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
-RUN: %run %t -runs=0 2>&1 | FileCheck %s
-
-With dead_strip, with trace-pc. Unused code is removed.
-RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -fsanitize-coverage=0 -fsanitize-coverage=trace-pc -Wl,-dead_strip
-RUN: nm %t | not grep UnusedFunctionShouldBeRemovedByLinker
-RUN: %run %t -runs=0 2>&1 | FileCheck %s
-
-With dead_strip, with pc-table. Unused code is not removed.
-RUN: %cpp_compiler %S/GcSectionsTest.cpp -o %t -ffunction-sections -fsanitize-coverage=0 -fsanitize-coverage=trace-pc-guard,pc-table -Wl,-dead_strip
-RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker | count 1
+RUN: nm %t | grep UnusedFunctionShouldBeRemovedByLinker
 RUN: %run %t -runs=0 2>&1 | FileCheck %s
 
 CHECK-NOT: ERROR: The size of coverage PC tables does not match




More information about the llvm-commits mailing list