[llvm] r352718 - GlobalISel: Don't call changingInstruction before giving up

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 18:22:39 PST 2019


Author: arsenm
Date: Wed Jan 30 18:22:39 2019
New Revision: 352718

URL: http://llvm.org/viewvc/llvm-project?rev=352718&view=rev
Log:
GlobalISel: Don't call changingInstruction before giving up

Modified:
    llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Modified: llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp?rev=352718&r1=352717&r2=352718&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp Wed Jan 30 18:22:39 2019
@@ -779,9 +779,9 @@ LegalizerHelper::LegalizeResult Legalize
   case TargetOpcode::G_SHL:
   case TargetOpcode::G_LSHR:
   case TargetOpcode::G_ASHR: {
-    Observer.changingInstr(MI);
     if (TypeIdx != 1)
       return UnableToLegalize; // TODO
+    Observer.changingInstr(MI);
     narrowScalarSrc(MI, NarrowTy, 2);
     Observer.changedInstr(MI);
     return Legalized;




More information about the llvm-commits mailing list