[PATCH] D57122: GlobalISel: Use helper function for MMO splitting

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 17:52:14 PST 2019


arsenm closed this revision.
arsenm added a comment.

r352716



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:501-502
-          MMO.getPointerInfo().getWithOffset(Adjustment), MMO.getFlags(),
-          NarrowSize / 8, Alignment, MMO.getAAInfo(), MMO.getRanges(),
-          MMO.getSyncScopeID(), MMO.getOrdering(), MMO.getFailureOrdering());
 
----------------
paquette wrote:
> I assume that `MMO.getAAInfo()`, `MMO.getRanges()`, etc are automatically handled by the call to `getMachineMemOperand` in `copyWithSizeAndOffset`? Or are they no longer relevant?
It turns out this already exists, it's just in MachineFunction instead of MMO


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57122/new/

https://reviews.llvm.org/D57122





More information about the llvm-commits mailing list