[PATCH] D57471: [LegalizeVectorTypes] Allow illegal indices when splitting extract_vector_elt

[Thomas Lively via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL352702: [LegalizeVectorTypes] Allow illegal indices when splitting extract_vector_elt (authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D57471?vs=184360&id=184406#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57471/new/

https://reviews.llvm.org/D57471

Files:
  llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/trunk/test/CodeGen/WebAssembly/PR40267.ll


Index: llvm/trunk/test/CodeGen/WebAssembly/PR40267.ll
===================================================================
--- llvm/trunk/test/CodeGen/WebAssembly/PR40267.ll
+++ llvm/trunk/test/CodeGen/WebAssembly/PR40267.ll
@@ -0,0 +1,22 @@
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers
+
+; Regression test for PR40267. Tests that invalid indices in
+; extract_vector_elt can be handled when vectors ops are split. Notice
+; that SIMD is not enabled for this test. Check only that llc does not
+; crash, since it would previously trigger an assertion.
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+define void @foo() {
+  %L6 = load i32, i32* undef
+  br label %BB1
+
+BB1:                                              ; preds = %BB1, %0
+  %bj = select <4 x i1> <i1 true, i1 true, i1 false, i1 false>, <4 x i32> <i32 55, i32 21, i32 92, i32 68>, <4 x i32> <i32 51, i32 61, i32 62, i32 39>
+  %E1 = extractelement <4 x i32> %bj, i32 0
+  %E23 = extractelement <4 x i32> zeroinitializer, i32 %E1
+  %I33 = insertelement <4 x i32> undef, i32 %E23, i1 undef
+  store <4 x i32> %I33, <4 x i32>* undef
+  br label %BB1
+}
Index: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
@@ -1919,7 +1919,6 @@
 
   if (isa<ConstantSDNode>(Idx)) {
     uint64_t IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
-    assert(IdxVal < VecVT.getVectorNumElements() && "Invalid vector index!");
 
     SDValue Lo, Hi;
     GetSplitVector(Vec, Lo, Hi);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57471.184406.patch
Type: text/x-patch
Size: 1799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/60905443/attachment.bin>