[PATCH] D57479: [WebAssembly] MC: Fix for outputing wasm object to /dev/null

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:405
+  if (!Size)
+    return;
+
----------------
sbc100 wrote:
> efriedma wrote:
> > It seems unsafe to assume all streams that don't support tell() are /dev/null.
> This code relies on OS.tell() working...  if OS.tell() doesn't work should we abort instead?   Then we would break the /dev/null.   Are there other raw_pwrite_stream's that don't support OS.tell()?   It seems like the ability to pwrite would normally come with the ability to tell().
> 
There is precedence at raw_ostream.h:352 for handling a zero result from tell() to mean /dev/null.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57479/new/

https://reviews.llvm.org/D57479